Skip to content

New package: zed-0.231.1#59813

Open
JudahJL wants to merge 1 commit intovoid-linux:masterfrom
JudahJL:newpkg-zeditor
Open

New package: zed-0.231.1#59813
JudahJL wants to merge 1 commit intovoid-linux:masterfrom
JudahJL:newpkg-zeditor

Conversation

@JudahJL
Copy link
Copy Markdown
Contributor

@JudahJL JudahJL commented Apr 7, 2026

Testing the changes

  • I tested the changes in this PR: YES

New package

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (crossbuilds):
    • aarch64-glibc

@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Apr 7, 2026
@Nizarjh
Copy link
Copy Markdown
Contributor

Nizarjh commented Apr 8, 2026

dupllicate #58659

@JudahJL
Copy link
Copy Markdown
Contributor Author

JudahJL commented Apr 8, 2026

@Nizarjh I apologize for the duplicate pr.
didnt notice another pending pr.
I just wanted to add zed to the main repo as quickly as possible to use it asap.
Note: This one doesnt build the remote_server for now(commented it out). will do it at next update or if asked to do in review

@Nizarjh
Copy link
Copy Markdown
Contributor

Nizarjh commented Apr 8, 2026

@Nizarjh I apologize for the duplicate pr. didnt notice another pending pr. I just wanted to add zed to the main repo as quickly as possible to use it asap. Note: This one doesnt build the remote_server for now(commented it out). will do it at next update or if asked to do in review

u can use my template and patches for your own)

@JudahJL JudahJL force-pushed the newpkg-zeditor branch 2 times, most recently from 58e12fe to abf6b69 Compare April 9, 2026 02:18
@JudahJL JudahJL requested review from Duncaen and Nizarjh April 9, 2026 03:35
@Nizarjh
Copy link
Copy Markdown
Contributor

Nizarjh commented Apr 9, 2026

u need also change binary name from zed to smth with patch. u can look how i made this in my pr. But my pacth is not actual to new version. so do your own for this version of zed

@JudahJL
Copy link
Copy Markdown
Contributor Author

JudahJL commented Apr 9, 2026

u need also change binary name from zed to smth with patch. u can look how i made this in my pr. But my pacth is not actual to new version. so do your own for this version of zed

@Nizarjh I don't need to use that patch. I'm renaming the executable at do_install stage. There's also an additional check in the check build CI/CD that ensures no name conflicts occur in the executables(which successfully passes)

@Nizarjh
Copy link
Copy Markdown
Contributor

Nizarjh commented Apr 9, 2026

u need also change binary name from zed to smth with patch. u can look how i made this in my pr. But my pacth is not actual to new version. so do your own for this version of zed

@Nizarjh I don't need to use that patch. I'm renaming the executable at do_install stage. There's also an additional check in the check build CI/CD that ensures no name conflicts occur in the executables(which successfully passes)

oh i see. Sorry :)

@JudahJL JudahJL changed the title New package: zeditor-0.230.2 New package: zeditor-0.231.1 Apr 9, 2026
pkgname=zeditor
version=0.231.1
revision=1
archs="x86_64 aarch64"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
archs="x86_64 aarch64"
archs="x86_64* aarch64*"

Copy link
Copy Markdown
Contributor Author

@JudahJL JudahJL Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't compile successfully on musl versions locally

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then that is a merge blocker, there is no reason it shouldn't work with musl.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of dependencies not existing in one of the musl version. For details, I'll let you know when I get home

Copy link
Copy Markdown
Contributor Author

@JudahJL JudahJL Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x86_64-linux-musl:

ERROR: Could not find package 'cross-x86_64-linux-musl'
=> ERROR: cross-x86_64-linux-musl-0.37_5: cannot be built, it's currently broken; see the build log:
=> ERROR: cross-x86_64-linux-musl-0.37_5: Can't build crosstoolchain to itself

aarch64-musl:

error: failed to run custom build command for `prost-build v0.9.0`
        
Caused by:
process didn't exit successfully: `/builddir/zed-0.231.1/target/release/build/prost-build-b23121bcf79afb3f/build-script-build` (exit status: 101)
--- stderr
        
thread 'main' (12773) panicked at /host/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/prost-build-0.9.0/build.rs:105:10:
Failed to find the protoc binary. The PROTOC environment variable is not set, there is no bundled protoc for this platform, and protoc is not in the PATH
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try -A

@@ -0,0 +1,61 @@
# Template file for 'zeditor'
pkgname=zeditor
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the package name is a good choice.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

@Duncaen Duncaen Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary != package name and you named the binary different from that too. There is no reason to not name the package "zed".

Copy link
Copy Markdown
Contributor Author

@JudahJL JudahJL Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://zed.dev/docs/development/linux#other-things-to-note

There are a couple of other zed binaries that may be present on Linux systems (1, 2). If you want to rename our CLI binary because of these issues, we suggest zedit, zeditor, or zed-cli.

initial thoughts were to make the binary and package name both to zeditor, so its easy to remember.

Then zed-editor(GUI) and zeditor(cli) was confusing, therefore chose zed-cli

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally use upstream package names, and since there is no existing "zed" package, I don't think there is a reason to not use that name.

Copy link
Copy Markdown
Contributor Author

@JudahJL JudahJL Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name for cli?

Comment on lines +41 to +42
local app_id="dev.zed.Zed"
local app_cli_name="zed-cli"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove those variables, they are mostly useless. Also not sure if "zed-cli` is a good choice, no other distribution calls it that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vars are there for easy refactoring only. Couldn't think of better names. Suggestions are welcome

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't optimize for easy refactoring. Its not a variable, don't make it more complicated than it has to be.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better rename to zed-editor. package name also

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Copy Markdown
Contributor Author

@JudahJL JudahJL Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/void-linux/void-packages/pull/59813/changes#diff-9648758f25f2c11ddeb1d522b1e46f036962042cb4270d1cb9b7b7b85893b2beR45

zed-editor is already used. the suggested names were zedit, zeditor, or zed-cli.

Thought to name it zeditor for both package name and cli but then zed-editor(GUI) and zeditor(cli) was confusing, therefore chose zed-cli

suggested names are from here:
https://zed.dev/docs/development/linux#other-things-to-note

There are a couple of other zed binaries that may be present on Linux systems (1, 2). If you want to rename our CLI binary because of these issues, we suggest zedit, zeditor, or zed-cli.

@JudahJL JudahJL changed the title New package: zeditor-0.231.1 New package: zed-0.231.1 Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-package This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants