Conversation
|
dupllicate #58659 |
|
@Nizarjh I apologize for the duplicate pr. |
u can use my template and patches for your own) |
58e12fe to
abf6b69
Compare
|
u need also change binary name from zed to smth with patch. u can look how i made this in my pr. But my pacth is not actual to new version. so do your own for this version of zed |
@Nizarjh I don't need to use that patch. I'm renaming the executable at do_install stage. There's also an additional check in the check build CI/CD that ensures no name conflicts occur in the executables(which successfully passes) |
oh i see. Sorry :) |
srcpkgs/zeditor/template
Outdated
| pkgname=zeditor | ||
| version=0.231.1 | ||
| revision=1 | ||
| archs="x86_64 aarch64" |
There was a problem hiding this comment.
| archs="x86_64 aarch64" | |
| archs="x86_64* aarch64*" |
There was a problem hiding this comment.
Didn't compile successfully on musl versions locally
There was a problem hiding this comment.
Then that is a merge blocker, there is no reason it shouldn't work with musl.
There was a problem hiding this comment.
Because of dependencies not existing in one of the musl version. For details, I'll let you know when I get home
There was a problem hiding this comment.
x86_64-linux-musl:
ERROR: Could not find package 'cross-x86_64-linux-musl'
=> ERROR: cross-x86_64-linux-musl-0.37_5: cannot be built, it's currently broken; see the build log:
=> ERROR: cross-x86_64-linux-musl-0.37_5: Can't build crosstoolchain to itself
aarch64-musl:
error: failed to run custom build command for `prost-build v0.9.0`
Caused by:
process didn't exit successfully: `/builddir/zed-0.231.1/target/release/build/prost-build-b23121bcf79afb3f/build-script-build` (exit status: 101)
--- stderr
thread 'main' (12773) panicked at /host/cargo/registry/src/index.crates.io-1949cf8c6b5b557f/prost-build-0.9.0/build.rs:105:10:
Failed to find the protoc binary. The PROTOC environment variable is not set, there is no bundled protoc for this platform, and protoc is not in the PATH
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
srcpkgs/zeditor/template
Outdated
| @@ -0,0 +1,61 @@ | |||
| # Template file for 'zeditor' | |||
| pkgname=zeditor | |||
There was a problem hiding this comment.
I don't think the package name is a good choice.
There was a problem hiding this comment.
There was a problem hiding this comment.
Binary != package name and you named the binary different from that too. There is no reason to not name the package "zed".
There was a problem hiding this comment.
https://zed.dev/docs/development/linux#other-things-to-note
There are a couple of other zed binaries that may be present on Linux systems (1, 2). If you want to rename our CLI binary because of these issues, we suggest zedit, zeditor, or zed-cli.
initial thoughts were to make the binary and package name both to zeditor, so its easy to remember.
Then zed-editor(GUI) and zeditor(cli) was confusing, therefore chose zed-cli
There was a problem hiding this comment.
We generally use upstream package names, and since there is no existing "zed" package, I don't think there is a reason to not use that name.
srcpkgs/zeditor/template
Outdated
| local app_id="dev.zed.Zed" | ||
| local app_cli_name="zed-cli" |
There was a problem hiding this comment.
Just remove those variables, they are mostly useless. Also not sure if "zed-cli` is a good choice, no other distribution calls it that.
There was a problem hiding this comment.
Vars are there for easy refactoring only. Couldn't think of better names. Suggestions are welcome
There was a problem hiding this comment.
We don't optimize for easy refactoring. Its not a variable, don't make it more complicated than it has to be.
There was a problem hiding this comment.
I think it's better rename to zed-editor. package name also
There was a problem hiding this comment.
zed-editor is already used. the suggested names were zedit, zeditor, or zed-cli.
Thought to name it zeditor for both package name and cli but then zed-editor(GUI) and zeditor(cli) was confusing, therefore chose zed-cli
suggested names are from here:
https://zed.dev/docs/development/linux#other-things-to-note
There are a couple of other zed binaries that may be present on Linux systems (1, 2). If you want to rename our CLI binary because of these issues, we suggest zedit, zeditor, or zed-cli.
Testing the changes
New package
Local build testing